-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clawback resync #15496
Clawback resync #15496
Conversation
Reopening because CI obviously only run conflicts checks here. |
This fix is not necessary for the release, close for now |
@ytx1991 The test you added in 91ac933 doesn't seem to pass. It still running on CI but times out here locally with the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a leftover from the retargeting to main
and two nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cloned main
and added this PR. I'm having trouble getting auto claim to work. This video shows when it fails (I did cut out a lot where nothing was happening, but I didn't cut the auto claim part):
Clawback.Autoclaim.main+15496.mp4
Here's my log from when the claim happened:
Here's another issue I saw while attempting to claw back a transaction. Note that this problem might not be related to this PR: nonetype.mp4Log snippet:
|
It seems like the clawback coin is missing for some reason. I assume it is related to wallet switching. For the auto claim, did you wait several minutes after the timelock expired? |
In this case for autoclaim, I switched to the receiver's wallet before the timelock expired. The autoclaim was then attempted in that wallet automatically as soon as the timelock expired. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Purpose:
Current Behavior:
New Behavior:
Testing Notes: